Replace || use in Query.duplicate for mysql compatibility #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysql doesn't use || for concat, unless set as a mode. Cleaned up code here.
ssweber
commented
Feb 17, 2023
Comment on lines
-1230
to
+1233
| q = f'UPDATE tmp SET {self.description_column} = "Copy of " || {self.description_column}' | ||
| q = f'UPDATE tmp SET {self.description_column} = "Copy of {description}"' |
There was a problem hiding this comment.
I don't understand how this was working before.
self.description_column was returning 'name' on the first call, but then in the 2nd f-string, it was returning the actual description, for instance 'Bill'. At first I changed it to just "Copy of {self.description_column}" to remove the ||. but then it returned 'name'.
You probably understand why. But I think grabbing the actually description at first is more explicit.
|
this relates to #74 |
|
Closing this for now, since you’ll be reworking a lot of these direct queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mysql doesn't use || for concat, unless set as a mode.
Cleaned up code here.