Import modules when init sqldriver driver #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This loads modules necessary for the sqldriver drivers on init, with a popup if module is not found.
|
|
|
Nice. I'll take a peek here shortly, I have some small jobs I'm finishing
up right now. I've been working on pytest unit tests tonight. I should
have a pull request in a few hours I think
…On Thu, Apr 13, 2023, 12:17 AM ssweber ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/57631333/231651669-7d888078-d2ed-4823-a4bd-d3ad0d0bde76.png>
here's how the popup looks.
—
Reply to this email directly, view it on GitHub
<#279 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQX2RES5NZ7COQGT4433G23XA545JANCNFSM6AAAAAAW4QS3NU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
PySimpleSQL
requested review from
PySimpleSQL
and removed request for
PySimpleSQL
|
I have no idea what happened, I can't find the review button anywhere |
PySimpleSQL
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using my new write powers to work in the main pysimplesql repository! Now you can easily try out my changes before committing :)
This loads modules necessary for the sqldriver drivers on their init, with a popup if module is not found. So now a user doesn't need to install all database drivers, just to use sqlite. Then we can add all the optionals to setup.py
I tested this, and it works ok... but let me know if there is a more clean way without using global.
What are your thoughts on external requirements? Like the ODBC for sqlserver, or java jre for access?