Implement delete_cascade Relationship functions and code (and ttk buttons and quick_editor fix) #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, this adds delete_cascade grabbing to Sqlite, Mysql and Postgres. For the Form init, a user can toggle off update_cascade / delete_cascade by setting them False. If a user has an update_cascade for a field they don't want to use for requerying, they can use the new `update_fk_relationship` to set update_cascade or delete_cascade to False.
Quick editor was breaking tcl after closing. Adding a unique key fixed it. (closing quick_editor, and then clicking the sg.Table selector of the same quick-editor) Also added modal = True to block main screen while quick editor open.
ssweber
changed the title
|
After this lands, I’ll probably rename update_fk_relationship to set_fk_cascade to be more clear? |
|
update_fk_cascade_rule? Idk, I’m open to suggestions. |
|
Whatever you think on naming - at least there is a mechanism there for those that need it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this adds delete_cascade grabbing to Sqlite, Mysql and Postgres.
For the Form init, a user can toggle off update_cascade / delete_cascade by setting them False.
If a user has an update_cascade for a field they don't want to use for requerying, they can use the new
update_fk_relationshipto set update_cascade or delete_cascade to False.eg
frm.update_fk_relationship('bike_repair','bike_id',update_cascade=False)I think that covers all our bases. If a user uses Foreign Key constraints, they can just turn delete_cascade to False and let the database do the work.