Fix sqldriver to not delete NON update_cascade children #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found when testing 'PRAGMA foreign_keys = ON' that current sqldriver was deleting records that only used foreign-key in drop-downs.. not as update_cascade
Closed
Added the 'children deleted' list to delete, like it has in duplicate... otherwise there can be multiple deletes to the same table. Added a popup for exceptions to delete.
ssweber
commented
Mar 7, 2023
| @@ -4335,7 +4340,7 @@ def delete_record(self, dataset: DataSet, cascade=True): # TODO: get ON DELETE C | |||
| table = self.quote_table(dataset.table) | |||
| pk_column = self.quote_column(dataset.pk_column) | |||
| q = f'DELETE FROM {table} WHERE {pk_column}={dataset.get_current(dataset.pk_column)};' | |||
| self.execute(q) | |||
| return self.execute(q) | |||
There was a problem hiding this comment.
This really is only popups an exception on the parent execute. I figure you’re going to rework this a bit for delete_cascade / to be recursive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when testing 'PRAGMA foreign_keys = ON' that current sqldriver was deleting records that only used foreign-key in drop-downs.. not as update_cascade