Skip to content

Don't use PyTuple_Resize #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 3, 2020
Merged

Don't use PyTuple_Resize #436

merged 9 commits into from
Jul 3, 2020

Conversation

methane
Copy link
Member

@methane methane commented Jul 2, 2020

It is unsafe.

Fixes #435.
See also #348.

@PyMySQL PyMySQL deleted a comment from codecov bot Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          12       12           
  Lines        1536     1536           
=======================================
  Hits         1331     1331           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0887495...52bd513. Read the comment docs.

@methane methane closed this Jul 2, 2020
@methane methane reopened this Jul 2, 2020
@methane
Copy link
Member Author

methane commented Jul 3, 2020

It seems Django tests uses much memory and Travis-Ci can not finish the test.
I am running the test locally.

@methane methane merged commit a825b84 into PyMySQL:master Jul 3, 2020
@methane methane deleted the ban-tupleresize branch July 3, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0: PyObject_GC_Track: Assertion failed: object already tracked by the garbage collector
1 participant