Skip to content

Remove py27 support from Python sources. #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 28, 2019
Merged

Conversation

Djailla
Copy link
Contributor

@Djailla Djailla commented Nov 6, 2019

No description provided.

@methane
Copy link
Member

methane commented Nov 7, 2019

I remove Python 2 support after 2020-01-01.

@methane methane added this to the v2.0 milestone Nov 18, 2019
@methane methane changed the title [compat] Remove py27 support as Python 2.7 will be deprecated beginni… Remove py27 support from Python sources. Nov 28, 2019
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #394 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   86.98%   86.64%   -0.35%     
==========================================
  Files          13       12       -1     
  Lines        1560     1535      -25     
==========================================
- Hits         1357     1330      -27     
- Misses        203      205       +2
Impacted Files Coverage Δ
MySQLdb/cursors.py 80.84% <100%> (-0.15%) ⬇️
MySQLdb/_exceptions.py 100% <100%> (ø) ⬆️
MySQLdb/connections.py 80.28% <100%> (-2.04%) ⬇️
MySQLdb/converters.py 82.35% <100%> (-0.51%) ⬇️
MySQLdb/__init__.py 83.33% <100%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a75ea...34399d3. Read the comment docs.

@methane methane merged commit 026e87f into PyMySQL:master Nov 28, 2019
@methane
Copy link
Member

methane commented Nov 28, 2019

thanks

@Djailla Djailla deleted the py27 branch November 28, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants