Skip to content

Fix description of SEGV issue in HISTORY #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Mar 2, 2019

I looked into the related issues and think that the description is quite misleading or may be wrong.

@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files          13       13           
  Lines        1556     1556           
=======================================
  Hits         1356     1356           
  Misses        200      200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7893c5a...5eb111a. Read the comment docs.

@methane
Copy link
Member

methane commented Mar 3, 2019

Only rollback is affected?

@carsonip
Copy link
Contributor Author

carsonip commented Mar 3, 2019

I checked the v1.3.13 code, there was no checking for rollback() and commit(). Not sure whether it will cause SEGV tho. 4a4978d#diff-b86fdc88461d69279e84018bca8ea267R879
Any thoughts?

@methane
Copy link
Member

methane commented Mar 4, 2019

What did you confirmed?
I get report only for close(). I added checks for many functions, not only close() and rollback().

@carsonip
Copy link
Contributor Author

carsonip commented Mar 4, 2019

I would say it at least affects rollback() according to #270. But I'll reproduce the segfault later today and see what functions are exactly affected.

@methane methane merged commit 1a67ae2 into PyMySQL:master Mar 4, 2019
@methane
Copy link
Member

methane commented Mar 4, 2019

I changed the history entry to not refer to actual method name causing SEGV.

@carsonip
Copy link
Contributor Author

carsonip commented Mar 4, 2019

The description looks better now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants