Skip to content

Add some garbage for Django 1.11 compatibility #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Add some garbage for Django 1.11 compatibility #327

merged 3 commits into from
Feb 7, 2019

Conversation

methane
Copy link
Member

@methane methane commented Jan 30, 2019

Django touched private area of this library.
Removing unused variables broke Django.

While Django 2.0 fixed it, Django 1.11 LTS doesn't fix it
because Django 1.11 is in security-only fix mode.

So add unused variables for Django 1.11 compatibility.
They will be removed in 1.5.

Fix #303, #306

Django touched private area of this library.
Removing unused variables broke Django.

While Django 2.0 fixed it, Django 1.11 doesn't fix it
because it is in security-only fix mode.

So add unused variables for Django 1.11 compatibility.
They will be removed in next minor release.

Fix #303, #306
@methane methane merged commit 1f6e18d into PyMySQL:master Feb 7, 2019
@methane methane deleted the add-garbage branch February 7, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures after upgrading Django app to mysqlclient 1.3.14
1 participant