fix(webpack): bundling with uglify #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the global __extend, __decorate, etc. functions will be used and they won't be renamed when running webpack. This is important because the static binding generator looks for nodes with these names when traversing the js sources for native extenders.
| @@ -0,0 +1,3 @@ | |||
| // There is a bug in angular: https://github.com/angular/angular-cli/pull/8589/files | |||
| // Legendary stuff, its webpack plugin pretty much doesn't work with empty TypeScript files in v1.8.3 | |||
VladimirAmiorkov
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the global __extend, __decorate, etc. functions will be used
and they won't be renamed when running webpack. This is important
because the static binding generator looks for nodes with these names
when traversing the js sources for native extenders.
fixes NativeScript/nativescript-dev-webpack#265