This repository was archived by the owner on May 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue-meta を使おう |
gedorinku
reviewed
Apr 8, 2019
<h2>部員募集中!</h2> | ||
<p> | ||
久留米高専プロラボ部は平日授業を終えた学生が集まり次第、電気電子・制御情報工学科棟のSJ(制御情報実験室)で活動しています。<br> | ||
興味のある方は、活動時間にSJ教室を訪ねてみてくださいね! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この文言変えたいなぁ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あとで考える
/* eslint-enable no-param-reassign */ | ||
actions: { | ||
async getAchievements({ commit }, sessionID) { | ||
commit('setAchievements', await achievementClient.getAchievements(sessionID)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
エラーハンドリングしてcriticalErrorに入れたい
Open
Merged
…nal+gedorinku/critical_error 実績一覧のエラーハンドリング
…ient into achievements-list-provisional
Fukusan64
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
はい、かっこいい
諸事情でログインしてからのところを実際に見られなかったけど
ログインとかのリンクが変わるだけっぽいし大丈夫そう
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
仮でもトップページが無いと開発に支障がありそうなので作った(トップページだけ先に master にマージしたほうが良いならそうします)
戦歴リストは仕様固まってないですが、ひとまず確認用