Partially move document formatting to server side #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 12, 2017 18:14
daviwil
reviewed
Jun 13, 2017
| @@ -286,158 +247,12 @@ class PSDocumentFormattingEditProvider implements | |||
| PSDocumentFormattingEditProvider.documentLocker.lock(document, unlockWhenDone); | |||
| } | |||
|
|
|||
| private executeRulesInOrder( | |||
There was a problem hiding this comment.
So happy this is gone now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step closer towards moving document formatting completely to server side. The logic could not be moved completely because vscode doesn't appear to send updated values of
tabSizeandinsertSpaceswhen sendingtextDocument/formattingor any other formatting related request. Hence, we register the providers on the client side and then manually send thetextDocument/rangeFormattingrequest. The code is designed such that eventextDocument/formattingandtextDocument/onTypeFormattingrequests are handled bytextDocument/rangeFormatting. This is done to minimize code duplication.As and when the
tabSizeandinsertSpacesissues get resolved, we will only need to enable the formatting capabilities on server and add atextDocument/onTypeFormattinghandler to completely move formatting to server-side.Related PRs:
This and the related PRs should also help use resolve the following issues: