Send document Uri instead of path for extension command execution #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue which causes the language server to crash when running a registered $psEditor command from within an untitled file. This happens because the workspace code in the language server expects to receive Uri paths instead of local file paths when referring to an editor buffer. The fix is to send the untitled file's Uri instead of its non-existent file path. Resolves PowerShell#810. Resolves PowerShell/PowerShellEditorServices PowerShell#434.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue which causes the language server to crash
when running a registered $psEditor command from within an untitled
file. This happens because the workspace code in the language server
expects to receive Uri paths instead of local file paths when referring
to an editor buffer. The fix is to send the untitled file's Uri instead
of its non-existent file path.
Resolves #810.
Resolves PowerShell/PowerShellEditorServices #434.