Skip to content

Add formatting option to align property value pairs #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2017

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Apr 21, 2017

Kapil Borle added 3 commits April 20, 2017 19:14
The property value pairs defined in a DSC configuration are in fact key value pairs of a hashtable. This can be easily verified by parsing a DSC configuration and examining the AST nodes. However, while naming they are referred to as part of DSC configuration and not a hashtable. Therefore the option name "alignAssignmentsInHashtable" would sound somewhat misleading to users, if enabling the option would format even the property value pairs in a DSC configuration.
package.json Outdated
"powershell.codeFormatting.alignPropertyValuePairs": {
"type": "boolean",
"default": true,
"description": "Align assignment statements in a hashtable."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expand this description to include "or a DSC configuration"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@daviwil
Copy link
Contributor

daviwil commented Apr 22, 2017

:shipit:

@kapilmb
Copy link
Author

kapilmb commented Apr 22, 2017

Thanks @daviwil !

@kapilmb kapilmb merged commit 7821670 into develop Apr 22, 2017
@kapilmb kapilmb deleted the kapilmb/format-align-assignment branch April 22, 2017 00:41
@daviwil daviwil modified the milestones: 1.0.0-beta1, 1.0.0 May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants