Skip to content

Fix hang caused when format on type is enabled #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2017

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Mar 30, 2017

The formatter would go into an infinite loop in certain cases because formatting edits were not filtered in the right way.

Fixes #595

@daviwil
Copy link
Contributor

daviwil commented Mar 30, 2017

Looks good, thanks man!

@daviwil daviwil added this to the 0.12.0 milestone Mar 30, 2017
@kapilmb kapilmb merged commit adcf152 into develop Mar 30, 2017
@kapilmb kapilmb deleted the kapilmb/format-on-type-hang branch March 30, 2017 22:09
@kapilmb
Copy link
Author

kapilmb commented Mar 30, 2017

Thanks @daviwil !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants