Skip to content

Fix #599: SSASCMDLETS module cannot be loaded #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Fix #599: SSASCMDLETS module cannot be loaded #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,17 @@ export class SessionManager {
this.isWindowsOS = os.platform() == "win32";

// Get the current version of this extension
this.hostVersion =
vscode
.extensions
.getExtension("ms-vscode.PowerShell")
.packageJSON
.version;
// NOTE: Report the host version as 1.0.0 for now to avoid
// issues loading the SSASCMDLETS module from SQL Server
// Analytics Service. Once we ship 1.0 of the extension,
// this will be changed back to the actual ext version.
// (part of a fix for PowerShell/vscode-powershell#599).
this.hostVersion = "1.0.0";
// vscode
// .extensions
// .getExtension("ms-vscode.PowerShell")
// .packageJSON
// .version;

// Fix the host version so that PowerShell can consume it.
// This is needed when the extension uses a prerelease
Expand Down