Skip to content

Fix: Change DAP send/receive glyph to keep things aligned in the logs #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix: Change DAP send/receive glyph to keep things aligned in the logs #5076

merged 1 commit into from
Oct 31, 2024

Conversation

JustinGrote
Copy link
Collaborator

PR Summary

Changes logging glyph from ◀️ to ⬅️ which has better ZWF formatting in logs

@JustinGrote JustinGrote self-assigned this Oct 31, 2024
@JustinGrote JustinGrote enabled auto-merge October 31, 2024 16:50
@JustinGrote JustinGrote added Bug: Pre-release Bugs reproducing only in the pre-release extension. Area-Logging labels Oct 31, 2024
@JustinGrote JustinGrote added this pull request to the merge queue Oct 31, 2024
@andyleejordan andyleejordan added the Issue-Bug A bug to squash. label Oct 31, 2024
@andyleejordan andyleejordan removed this pull request from the merge queue due to a manual request Oct 31, 2024
@andyleejordan
Copy link
Member

@JustinGrote are you sure you have the right right-arrow? I'd expect to see ➡️ since I'm seeing ⬅️ but I'm seeing ➡️...which I just copy-pasted and it shows correctly here. GitHub isn't rendering it well in the file diff 😭

@andyleejordan
Copy link
Member

Screenshot 2024-10-31 at 10 18 46 AM

JustinGrote
JustinGrote commented Oct 31, 2024
View reviewed changes
Copy link
Collaborator Author

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me re-verify but it looked good in code

@JustinGrote
Copy link
Collaborator Author

Looks fine to me in Github...
image

And in Code:
image

@JustinGrote
Copy link
Collaborator Author

Files changed tab looks fine to me too in github on the PR:
image

Are you on a Mac or something? Also using edge browser here.

@JustinGrote JustinGrote added this pull request to the merge queue Oct 31, 2024
@JustinGrote
Copy link
Collaborator Author

Checking the glyph codepoints they look good to me, so I'm going to go ahead and merge queue it. If we find something's wrong with the code points we can fix-forward, but again since this is just the DAP trace log and not user-facing it's not a big deal either way.

Merged via the queue into main with commit dbae6ab Oct 31, 2024
7 checks passed
@JustinGrote JustinGrote deleted the fix/changeDAPGlyph branch October 31, 2024 17:49
@andyleejordan
Copy link
Member

Files changed tab looks fine to me too in github on the PR: image

Are you on a Mac or something? Also using edge browser here.

Yeah, in Edge on a Mac. It's weird! No worries though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees

@JustinGrote JustinGrote

Labels
Area-Logging Bug: Pre-release Bugs reproducing only in the pre-release extension. Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinGrote @andyleejordan