Enable formatOnType feature #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilmb
changed the title
|
Needs rebase after #501 is merged. |
daviwil
approved these changes
Feb 14, 2017
| "powershell", | ||
| this.documentFormattingEditProvider, | ||
| this.firstTriggerCharacter, | ||
| ...this.moreTriggerCharacters); |
There was a problem hiding this comment.
This is such a bizarre way for them to define this API... If it's a new API why have a "first" param and then a "more" param? Weird.
There was a problem hiding this comment.
Yes, they could just have one argument taking in triggerCharacters instead of this!
added 5 commits
February 14, 2017 10:44
kapilmb
force-pushed
the
kapilmb/format-on-type
branch
from
13d121c to
1160398
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables "editor.formatOnType" option in vscode settings.
Related PR: PowerShell/PowerShellEditorServices#370