Replace PAT with WIF in publish step #4984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can no longer use Dependabot due to CFS, we just have to update manually (with `--save`, but automatic). Which means we need `^` semver so `npm update` does what we expect (which is to update to the latest minor version). Except for the VS Code types, those use `~` so we only get patch updates. This is because it must match our engine version of VS Code. Also just omit the resolved registry from the lockfile (since the replace option didn't really work as expected)
Since we can no longer use Dependabot due to CFS, we just have to update manually (with `--save`, but automatic). Which means we need `^` semver so `npm update` does what we expect (which is to update to the latest minor version). Except for the VS Code types, those use `~` so we only get patch updates. This is because it must match our engine version of VS Code. Also just omit the resolved registry from the lockfile (since the replace option didn't really work as expected).
The latest version of the tool will use the Azure API to grab a token, it just needs to be run in a context where Azure CLI is authenticated. I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies now that we don't have Dependabot, and use
--azure-credentialwith a service connection in Azure DevOps to publish.