First phase of streamlined development setup #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves our handling of the bundledModulesPath setting by only making it active when VS Code is in development mode (either running in the debugger or with the --extensionDevelopmentPath setting). This enables extension developers to use their installed PowerShell extension's bundled modules in normal circumstances, only switching to the bundledModulesPath when they are running a development build. This code also sets the default bundledModulesPath to a peer (co-located) PowerShellEditorServices folder since most developers will probably clone the two repos into the same folder. One would only need to set their bundledModulesPath if their PSES repo folder was in an unconventional path. The bundledModulesPath setting will likely be renamed to something more appropriate in the next update.
|
O hai AppVeyor. Haven't set that up yet... |
This change introduces a new vscode-powershell.build.ps1 script powered by Invoke-Build. The goal of this script is to handle build tasks which would affect both the PowerShell extension and PowerShell Editor Services so that it's much easier to hit F5 and build everything before launching the debugger. This is also a starting point for release automation so we can start shipping faster!
daviwil
force-pushed
the
daviwil/new-dev-setup
branch
from
dd36d39 to
4e60081
Compare
|
F5 Build -> Debug scenario works perfectly on Windows and Linux. Merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #456, I'd like to streamline the development process for the PowerShell extension so that its easier for others to contribute. This change establishes a new build script which can compile both the extension code and PowerShell Editor Services so that all development can be done inside of VS Code. This development setup should work across Windows, Linux, and macOS.
Before merging I'm going to make sure that I can pull the changes for both this PR and PowerShell/PowerShellEditorServices#351 and build everything from scratch just by hitting F5, both on Windows and Ubuntu 16.04.