Skip to content

Bump @ungap/structured-clone from 1.0.2 to 1.2.0 #4556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 3, 2023

Bumps @ungap/structured-clone from 1.0.2 to 1.1.2.

Commits
  • a7b5f81 1.1.2
  • 41eaf8b Fix #16 - Rollback too-strict types
  • 6c7a23a 1.1.1
  • 6db2084 Fix #17 - make options optional
  • 8d363e5 1.1.0
  • d1dbcba Added types to exports + updated dev-dependencies
  • 9870aff Merge pull request #15 from andrew-pyle/feature/d-ts
  • 8f998aa Add caveat about TS target/lib requirement
  • b730556 Remove BigInt64Array from the Cloneable type, since it requires the TS es2020...
  • bc44074 Generate CJS .d.ts files from ESM .d.ts files
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@ungap/structured-clone](https://github.com/ungap/structured-clone) from 1.0.2 to 1.1.2.
- [Release notes](https://github.com/ungap/structured-clone/releases)
- [Commits](ungap/structured-clone@v1.0.2...v1.1.2)

---
updated-dependencies:
- dependency-name: "@ungap/structured-clone"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bump Structured Clone
@JustinGrote JustinGrote changed the title Bump @ungap/structured-clone from 1.0.2 to 1.1.2 Bump @ungap/structured-clone from 1.0.2 to 1.2.0 May 4, 2023
@JustinGrote
Copy link
Collaborator

So the problem here is that 1.1.0 introduced some type files but didn't type the types.js file. I'm trying to think of the best way to work around this.
ungap/structured-clone#16 (comment)

@JustinGrote JustinGrote requested a review from a team as a code owner May 4, 2023 17:10
Copy link
Collaborator

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be OK now, I basically ignored the "bad" types from the source repo in favor of the definitelytyped ones. Per the comment discussion this will probably eventually be fixed and the tsconfig exclude can be removed.

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Justin!

@andyleejordan andyleejordan merged commit 2f83a1c into main May 4, 2023
@andyleejordan andyleejordan deleted the dependabot/npm_and_yarn/ungap/structured-clone-1.1.2 branch May 4, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants