Update startup logic to handle session failure reasons #4543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These used to be sent given that the logic existed, but the server was no longer sending them at all. Now that it does, we can handle them.
Otherwise you could add and you'd have to restart to get an updated menu!
Now we dispose on the exited event (so we don't have to do it in the catch around `start`). We subscribe the `onDidCloseTerminal` event right before creating the terminal so it fires even if the terminal immediately closes. We check if the terminal is still defined (not crashed) when waiting for the session file.
Grab it off the executable details since it won't be coming from the LSP request.
andyleejordan
force-pushed
the
andschwa/failure-reasons
branch
from
76716f8 to
2d74846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These used to be sent given that the logic existed, but the server was no longer sending them at all. Now that it does, we can handle them. Also see PowerShell/PowerShellEditorServices#2018.