Skip to content

Enable VS Code unit tests in Linux CI #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Apr 10, 2023

Now that they can run (with the addition of xvfb), resolves #4502.

@andyleejordan andyleejordan requested a review from a team April 10, 2023 17:40
@andyleejordan andyleejordan requested a review from a team as a code owner April 10, 2023 17:40
@ghost ghost added Area-Build & Release Issue-Enhancement A feature request (enhancement). labels Apr 10, 2023
@andyleejordan
Copy link
Member Author

@JustinGrote Ubuntu still finishes very fast but I confirmed the unit tests are now running. Great find, thank you!

Now that they can run (with the addition of xvfb)
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! LGTM!

@JustinGrote
Copy link
Collaborator

LGTM, we'll see if my hybrid module E2E tests still pass after I rebase :)

@andyleejordan andyleejordan merged commit 068d52e into main Apr 10, 2023
@andyleejordan andyleejordan deleted the andschwa/linux-ci branch April 10, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build & Release Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu CI Tests do not appear to be running
3 participants