Skip to content

Enable ESLint explicit-function-return-type #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2023
Merged

Enable ESLint explicit-function-return-type #4500

merged 1 commit into from
Apr 10, 2023

Conversation

andyleejordan
Copy link
Member

And fix violations.

Resolves #4498.

@andyleejordan andyleejordan requested a review from a team April 7, 2023 19:35
@andyleejordan andyleejordan requested a review from a team as a code owner April 7, 2023 19:35
@ghost ghost added Area-Tech Debt Issues for Tech Debt Days! Issue-Enhancement A feature request (enhancement). labels Apr 7, 2023
@andyleejordan andyleejordan enabled auto-merge (squash) April 7, 2023 19:37
SeeminglyScience
SeeminglyScience approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Love it. It always bothered me that this wasn't mandatory to begin with 😁

@andyleejordan andyleejordan merged commit 8f006fb into main Apr 10, 2023
@andyleejordan andyleejordan deleted the andschwa/explicit-function-return-type branch April 10, 2023 17:07
@andyleejordan
Copy link
Member Author

Same!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-Tech Debt Issues for Tech Debt Days! Issue-Enhancement A feature request (enhancement).
Projects
Flying Fox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable explicit-function-return-type ESLint rule
2 participants
@andyleejordan @SeeminglyScience