Skip to content

Remove problematic [RepoNames] PowerShell class #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

andyleejordan
Copy link
Member

It was admittedly over-engineered and caused problems since PowerShell classes aren't imported across modules.

Instead just use ValidateSet directly wherever the command is either use-facing or switches on the string directly.

It was admittedly over-engineered and caused problems since
PowerShell classes aren't imported across modules.

Instead just use `ValidateSet` directly wherever the command is either
use-facing or switches on the string directly.
@andyleejordan andyleejordan marked this pull request as ready for review March 27, 2023 20:11
@andyleejordan andyleejordan requested a review from a team March 27, 2023 20:11
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) March 27, 2023 20:19
@andyleejordan andyleejordan merged commit bdee932 into main Mar 27, 2023
@andyleejordan andyleejordan deleted the andschwa/validateset branch March 27, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants