Remove preview label from marketplace
#4464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/no-preview
branch
3 times, most recently
from
1b2cf5e to
55f98e1
Compare
We were using this as an easy way to determine if the version is a pre-release. However, the marketplace always looks a the latest version meaning it was placing a "preview" label and our preview icon on the webpage. So we had to write a different way to determine if the extension is a pre-release.
andyleejordan
force-pushed
the
andschwa/no-preview
branch
3 times, most recently
from
c6f8c4c to
394209f
Compare
So the GitHub module isn't required.
andyleejordan
force-pushed
the
andschwa/no-preview
branch
from
394209f to
ca9a5c2
Compare
Since it's required in order to use our version tools.
andyleejordan
force-pushed
the
andschwa/no-preview
branch
from
ca9a5c2 to
a80f796
Compare
andyleejordan
added
Issue-Enhancement
Since I do actually plan to use it to preview a PSReadLine preview.
SeeminglyScience
requested changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a lot of annoying work just to remove the
previewlabel from the marketplace web page, since it shows from the "latest" (inclusive of pre-release) releases. Our only other way to determine at package and release time that a version is a pre-release is to re-use the version-from-changelog logic of the release tools. But that meant splitting out the relevant parts so the build script didn't take a dependency on thePowerShellForGitHubmodule, and splitting the CI into a "build and package" step separate from a "test" step. The latter happened because in CI we test against PowerShell 5.1...and that doesn't have thesemvertype, so it couldn't use the version logic, hence the "build and package" step now requires PowerShell Core. 🙃But hey, at least I snuck in a fix for a long-standing
TODOto better validate the version number we hand to the release tools when doing a release.