Don't send empty environment vars when not Windows PowerShell dev build #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue where $env:PROCESSOR_ARCHITECTURE is not being set properly in the language server's powershell.exe process which caused an exception when gathering that variable. The problem was caused by the environment variable setting behavior when the Windows PowerShell developer build setting is set to false. In this case, an empty environment variable object was being passed to the process, effectively clearing its environment variables. This is one half of the fix to PowerShell/PowerShellEditorServices#346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where $env:PROCESSOR_ARCHITECTURE is not being
set properly in the language server's powershell.exe process which caused
an exception when gathering that variable. The problem was caused by the
environment variable setting behavior when the Windows PowerShell
developer build setting is set to false. In this case, an empty
environment variable object was being passed to the process, effectively
clearing its environment variables.
This is one half of the fix to PowerShell/PowerShellEditorServices#346.