Hide last line in folded ranges for ISE Mode #4425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH I really like how the ISE handles this, but yeah even without the end characters I think this is good! |
andyleejordan
added
Issue-Enhancement
andyleejordan
approved these changes
Feb 21, 2023
andyleejordan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PowerShell ISE folds ranges to a single line unlike the current default in this extension:
This PR sets the
powershell.codeFolding.showLastLineoption tofalsein ISE mode to be more similar with ISE behavior.There is one major difference: ISE appended the closing char for most ranges which VSCode doesn't atm. That might be a dealbreaker, so submitting as a suggestion without discussion. Feel free to close if you don't agree.
PR Checklist