Skip to content

Improve "Attach to Host Process" menu flow #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Jan 18, 2017

This change improves the flow of the "Attach to Host Process" menu when
the language service hasn't started yet. It also changes the text display
slightly.

Here's a screenshot of the updated menu items:

image

This change improves the flow of the "Attach to Host Process" menu when
the language service hasn't started yet.  It also changes the text display
slightly.
@daviwil daviwil added this to the 0.9.0 milestone Jan 18, 2017
@daviwil
Copy link
Contributor Author

daviwil commented Jan 18, 2017

@rkeithhill let me know what you think about the text changes in the menu items. I noticed that the "detail" text was getting right-aligned for some weird reason, not sure if VS Code decided to do that somehow. I changed it to put everything in the description field so that it's more uniform.

@rkeithhill
Copy link
Contributor

LGTM! Glad you figured out a better way to handle the not-initialized case! BTW, can you verify that search in the quick pick works on the pid, as well as title and process name.

@daviwil
Copy link
Contributor Author

daviwil commented Jan 18, 2017

I learned some new things about Promises today, I can tell you that much ;) Yep, searching by pid works perfectly. Thanks Keith!

@daviwil daviwil merged commit 790e316 into master Jan 18, 2017
@daviwil daviwil deleted the daviwil/attach-menu-flow branch January 18, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants