Add startSessionCommand handler for debugger configuration #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm really happy with how well this works. And the best part is that it's compatible with VS Code 1.8.1 because it's only additive, no changes to existing debugger configurations, etc. I'll ship it with 0.9.0 and it'll light up as soon as VSC 1.9.0 ships. |
daviwil
changed the title
This change leverages the new "startSessionCommand" configuration parameter for debugger contributions which allows us to provide a command that will take a debug launch configuration, tweak it, and then launch the debugger ourselves. This allows us to do any necessary launching or pre-configuration of our debug adapter. It also allows us to create a default launch configuration on the fly if one doesn't already exist. This means that users can now debug the current script without a launch.json either with or without a folder open!
daviwil
force-pushed
the
daviwil/debug-launch
branch
from
989edc1 to
aa99387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change leverages the new "setSessionCommand" configuration parameter
for debugger contributions which allows us to provide a command that will
take a debug launch configuration, tweak it, and then launch the debugger
ourselves. This allows us to do any necessary launching or
pre-configuration of our debug adapter. It also allows us to create a
default launch configuration on the fly if one doesn't already exist.
This means that users can now debug the current script without a
launch.json either with or without a folder open!