Skip to content

Rewrite UpdatePowerShell feature #4306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vsts-ci/templates/ci-general.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ steps:
inputs:
targetType: inline
script: |
Get-ChildItem env:
Get-Module -ListAvailable Pester
Install-Module InvokeBuild -Scope CurrentUser -Force
Install-Module platyPS -Scope CurrentUser -Force
Expand Down
4 changes: 2 additions & 2 deletions src/features/Console.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import vscode = require("vscode");
import { NotificationType, RequestType } from "vscode-languageclient";
import { LanguageClient } from "vscode-languageclient/node";
import { ICheckboxQuickPickItem, showCheckboxQuickPick } from "../controls/checkboxQuickPick";
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { getSettings } from "../settings";
import { LanguageClientConsumer } from "../languageClientConsumer";

Expand Down Expand Up @@ -170,7 +170,7 @@ export class ConsoleFeature extends LanguageClientConsumer {
private commands: vscode.Disposable[];
private handlers: vscode.Disposable[] = [];

constructor(private logger: Logger) {
constructor(private logger: ILogger) {
super();
this.commands = [
vscode.commands.registerCommand("PowerShell.RunSelection", async () => {
Expand Down
8 changes: 4 additions & 4 deletions src/features/DebugSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { getPlatformDetails, OperatingSystem } from "../platform";
import { PowerShellProcess } from "../process";
import { IEditorServicesSessionDetails, SessionManager, SessionStatus } from "../session";
import { getSettings } from "../settings";
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { LanguageClientConsumer } from "../languageClientConsumer";
import path = require("path");
import utils = require("../utils");
Expand Down Expand Up @@ -65,7 +65,7 @@ export class DebugSessionFeature extends LanguageClientConsumer
},
};

constructor(context: ExtensionContext, private sessionManager: SessionManager, private logger: Logger) {
constructor(context: ExtensionContext, private sessionManager: SessionManager, private logger: ILogger) {
super();
// Register a debug configuration provider
context.subscriptions.push(vscode.debug.registerDebugConfigurationProvider("PowerShell", this));
Expand Down Expand Up @@ -359,7 +359,7 @@ export class PickPSHostProcessFeature extends LanguageClientConsumer {
private waitingForClientToken?: vscode.CancellationTokenSource;
private getLanguageClientResolve?: (value: LanguageClient) => void;

constructor(private logger: Logger) {
constructor(private logger: ILogger) {
super();

this.command =
Expand Down Expand Up @@ -485,7 +485,7 @@ export class PickRunspaceFeature extends LanguageClientConsumer {
private waitingForClientToken?: vscode.CancellationTokenSource;
private getLanguageClientResolve?: (value: LanguageClient) => void;

constructor(private logger: Logger) {
constructor(private logger: ILogger) {
super();
this.command =
vscode.commands.registerCommand("PowerShell.PickRunspace", (processId) => {
Expand Down
4 changes: 2 additions & 2 deletions src/features/ExtensionCommands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
Position, Range, RequestType
} from "vscode-languageclient";
import { LanguageClient } from "vscode-languageclient/node";
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { getSettings, validateCwdSetting } from "../settings";
import { LanguageClientConsumer } from "../languageClientConsumer";

Expand Down Expand Up @@ -149,7 +149,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
private handlers: vscode.Disposable[] = [];
private extensionCommands: IExtensionCommand[] = [];

constructor(private logger: Logger) {
constructor(private logger: ILogger) {
super();
this.commands = [
vscode.commands.registerCommand("PowerShell.ShowAdditionalCommands", async () => {
Expand Down
4 changes: 2 additions & 2 deletions src/features/ExternalApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import * as vscode from "vscode";
import { v4 as uuidv4 } from "uuid";
import { LanguageClientConsumer } from "../languageClientConsumer";
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { SessionManager } from "../session";

export interface IExternalPowerShellDetails {
Expand Down Expand Up @@ -39,7 +39,7 @@ export class ExternalApiFeature extends LanguageClientConsumer implements IPower
constructor(
private extensionContext: vscode.ExtensionContext,
private sessionManager: SessionManager,
private logger: Logger) {
private logger: ILogger) {
super();
}

Expand Down
4 changes: 2 additions & 2 deletions src/features/GetCommands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import * as vscode from "vscode";
import { RequestType0 } from "vscode-languageclient";
import { LanguageClient } from "vscode-languageclient/node";
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { LanguageClientConsumer } from "../languageClientConsumer";
import { getSettings } from "../settings";

Expand All @@ -30,7 +30,7 @@ export class GetCommandsFeature extends LanguageClientConsumer {
private commandsExplorerProvider: CommandsExplorerProvider;
private commandsExplorerTreeView: vscode.TreeView<Command>;

constructor(private logger: Logger) {
constructor(private logger: ILogger) {
super();
this.commands = [
vscode.commands.registerCommand("PowerShell.RefreshCommandsExplorer",
Expand Down
4 changes: 2 additions & 2 deletions src/features/NewFileOrProject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ import vscode = require("vscode");
import { RequestType } from "vscode-languageclient";
import { LanguageClient } from "vscode-languageclient/node";
import { LanguageClientConsumer } from "../languageClientConsumer";
import { Logger } from "../logging";
import { ILogger } from "../logging";

export class NewFileOrProjectFeature extends LanguageClientConsumer {

private readonly loadIcon = " $(sync) ";
private command: vscode.Disposable;
private waitingForClientToken?: vscode.CancellationTokenSource;

constructor(private logger: Logger) {
constructor(private logger: ILogger) {
super();
this.command =
vscode.commands.registerCommand("PowerShell.NewProjectFromTemplate", async () => {
Expand Down
4 changes: 2 additions & 2 deletions src/features/PesterTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import * as path from "path";
import vscode = require("vscode");
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { SessionManager } from "../session";
import { getSettings, chosenWorkspace, validateCwdSetting } from "../settings";
import utils = require("../utils");
Expand All @@ -17,7 +17,7 @@ export class PesterTestsFeature implements vscode.Disposable {
private commands: vscode.Disposable[];
private invokePesterStubScriptPath: string;

constructor(private sessionManager: SessionManager, private logger: Logger) {
constructor(private sessionManager: SessionManager, private logger: ILogger) {
this.invokePesterStubScriptPath = path.resolve(__dirname, "../modules/PowerShellEditorServices/InvokePesterStub.ps1");
this.commands = [
// File context-menu command - Run Pester Tests
Expand Down
4 changes: 2 additions & 2 deletions src/features/RunCode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import vscode = require("vscode");
import { SessionManager } from "../session";
import { Logger } from "../logging";
import { ILogger } from "../logging";
import { getSettings, chosenWorkspace, validateCwdSetting } from "../settings";

enum LaunchType {
Expand All @@ -14,7 +14,7 @@ enum LaunchType {
export class RunCodeFeature implements vscode.Disposable {
private command: vscode.Disposable;

constructor(private sessionManager: SessionManager, private logger: Logger) {
constructor(private sessionManager: SessionManager, private logger: ILogger) {
this.command = vscode.commands.registerCommand(
"PowerShell.RunCode",
async (runInDebugger: boolean, scriptToRun: string, args: string[]) => {
Expand Down
Loading