Skip to content

Skip auto-update on unsupported Windows architectures #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

andyleejordan
Copy link
Member

While PowerShell now works on ARM64 Windows, it does not yet have an MSI installer, so for now instead of erroneously attempting to install the x64 version, we just recommend that the user update (like we do for Linux). Note that the string is now capitalized due to a server-side change that simply returns .NET's
System.Runtime.InteropServices.Architecture enum as a string.

Paired with PowerShell/PowerShellEditorServices#1964, this resolves #3435.

While PowerShell now works on ARM64 Windows, it does not yet have an MSI
installer, so for now instead of erroneously attempting to install the
x64 version, we just recommend that the user update (like we do for
Linux). Note that the string is now capitalized due to a server-side
change that simply returns .NET's
`System.Runtime.InteropServices.Architecture` enum as a string.
@andyleejordan andyleejordan requested a review from a team December 2, 2022 17:58
@ghost ghost added Area-Startup Issue-Bug A bug to squash. labels Dec 2, 2022
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan
Copy link
Member Author

Screenshot 2022-12-02 at 11 17 38 AM

With an Arm64 pwsh on Windows, still get the update, but just with guidance!

@andyleejordan andyleejordan merged commit 4a1ffe0 into main Dec 2, 2022
@andyleejordan andyleejordan deleted the andschwa/architecture branch December 2, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension incorrectly attempts x64 update on Arm64 platform
2 participants