Skip to content

Refactor to reuse escapeSingleQuotes #4270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

Refactor to reuse escapeSingleQuotes #4270

merged 1 commit into from
Nov 18, 2022

Conversation

andyleejordan
Copy link
Member

Just a clean up done while investigating #4269.

@andyleejordan andyleejordan requested a review from a team November 17, 2022 22:01
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Ignore Exclude from the changelog. labels Nov 17, 2022
SeeminglyScience
SeeminglyScience approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 22bd44a into main Nov 18, 2022
@andyleejordan andyleejordan deleted the andschwa/escape-single-quotes branch November 18, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Ignore Exclude from the changelog. Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience