Refactor settings.ts
#4235
Merged
Refactor settings.ts
#4235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Enhancement
andyleejordan
force-pushed
the
andschwa/settings
branch
4 times, most recently
from
ac2d6ad to
237fb52
Compare
This feature never made it out of preview.
andyleejordan
force-pushed
the
andschwa/settings
branch
3 times, most recently
from
14a9121 to
aa7b026
Compare
This wasn't a "setting" anyway because it wasn't settable.
andyleejordan
force-pushed
the
andschwa/settings
branch
from
aa7b026 to
e7ba99f
Compare
andyleejordan
force-pushed
the
andschwa/settings
branch
from
e7ba99f to
0f5309e
Compare
|
Hm, this might break |
andyleejordan
force-pushed
the
andschwa/settings
branch
2 times, most recently
from
68be906 to
0e37854
Compare
andyleejordan
force-pushed
the
andschwa/settings
branch
from
0e37854 to
b9d56cf
Compare
Using recursion! With a test!
andyleejordan
force-pushed
the
andschwa/settings
branch
from
b9d56cf to
942a201
Compare
This setting was never meant to be changed!
As the client-side folder was removed eons ago.
|
Ok let's do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logging to our
changeSetting()function so we can track what settings the extension makes changes to (mostly because we're really confused howeditorServicesWaitForDebuggerkeeps getting turned on). It also finishes a clean up started in the strict-mode refactor to make the settings fields non-optional and uses a recursive function to populateISettingsfrom theWorkspaceConfiguration, complete with a regression test (which will fail if you run the tests from the launch config and have modified settings).