Update vscode-languageclient and refactor (a lot of TLC)
#4131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
andyleejordan
force-pushed
the
andschwa/update-lsp
branch
from
aeb44a4 to
43d054b
Compare
Also update our engine to align with ADS's update to 1.62.0. Unfortunately, we still have unresolved work pending their update to 1.65.0.
andyleejordan
force-pushed
the
andschwa/update-lsp
branch
from
43d054b to
1d96e16
Compare
SeeminglyScience
approved these changes
Aug 12, 2022
andyleejordan
force-pushed
the
andschwa/update-lsp
branch
from
0a64bf4 to
6e936f3
Compare
andyleejordan
added
Issue-Enhancement
Lots of clean-up, a little refactoring, and most importantly, a less buggy `LanguageClient` implementation (which is less prone to race conditions). Also handle disposal of handler registrations.
It's faster...it reads better.
The last one involves a stream.
This is necessary to take the language client library update. Unfortunately it means that ADS won't be able to take the next update to our extension until they catch up to at least this engine version. It could be worse, we didn't have to bump to 1.7x.
andyleejordan
force-pushed
the
andschwa/update-lsp
branch
from
6e936f3 to
e93425d
Compare
andyleejordan
changed the title
vscode-languageclient and refactorvscode-languageclient and refactor (a lot of TLC)
|
FYI @Charles-Gagnon we had to bump our engine to 1.65 in order to (finally) take the language client library update. What's ADS's ETA to merge 1.65? |
|
No exact ETA at this point in time - we're working on another update currently though (probably for October/November) that may get up that far, if not then it'll be sometime early next year. |
|
No worries, if you need we can back-port some patches and cut you a new release, but hopefully you can just take this one sooner rather than later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #4128 by eliminating race conditions in the
LanguageClient's connection process.