Always Base64 encode the startup command to avoid quoting issues #4116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already did this for non-Windows and it works great to avoid issues with quoting the server startup command. Let's do it on Windows too because some installations of PowerShell (specifically through the `dotnet` global tool) also have quote issues that became apparent with a multi-line startup banner.
ghost
added
andyleejordan
changed the title
|
We did this differently on Windows because some antiviruses have issues with EncodedCommand on Windows 😭 |
|
Yeahhh @SeeminglyScience told me such. I just did another workaround with #4121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already did this for non-Windows and it works great to avoid issues with quoting the server startup command. Let's do it on Windows too because some installations of PowerShell (specifically through the
dotnetglobal tool) also have quote issues that became apparent with a multi-line startup banner.Fixes #4111.