Skip to content

Fix edge case for workspaces defined with zero folders #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

andyleejordan
Copy link
Member

Wasn't catching the case where workspaceFolders itself is defined, but with a length of zero. Just didn't expect this to happen.

Fixes #4102.

Wasn't catching the case where `workspaceFolders` itself is defined, but
with a length of zero. Just didn't expect this to happen.
@andyleejordan andyleejordan requested a review from a team August 3, 2022 18:08
@ghost ghost added Area-Workspaces Issue-Bug A bug to squash. labels Aug 3, 2022
@andyleejordan andyleejordan enabled auto-merge (squash) August 3, 2022 18:10
@andyleejordan andyleejordan self-assigned this Aug 3, 2022
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extension doesn't start with when workspace is defined with zero folders
2 participants