Use context.storageUri for session file (and refactor)
#4088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
added
Issue-Enhancement
andyleejordan
commented
Jul 20, 2022
| debugServicePipeName: string; | ||
| } | ||
|
|
||
| export type IReadSessionFileCallback = (details: IEditorServicesSessionDetails) => void; |
There was a problem hiding this comment.
I can't find what this was used for...delete it?
andyleejordan
force-pushed
the
andschwa/session-path
branch
from
ec15a0a to
1eb62cd
Compare
Note that we seemed to be unnecessarily writing a new debug session file for the `RunCode` and `PesterTests` features; they work fine without that logic as the debugger itself handles the session file.
No idea why we were writing it as the client. Maybe I've totally misunderstood, but everything works as expected without this (and moreover, we delete any existing session file and then wait for it, after passing the path to the server).
As that's the only place they're used.
Since `cwd` can be `undefined` we need to use optional chaining.
andyleejordan
force-pushed
the
andschwa/session-path
branch
from
1eb62cd to
5f80a6e
Compare
SeeminglyScience
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
LGTM!
I think originally it used to write the session file first and wait for it to be populated... something like that? Can't remember if it was a strange limitation of the time or just accidental over engineering but either way can probably just be dropped 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a decent cleanup of our session file logic in the client, so it needs a close review. Most important note is that I completely removed
writeSessionFile...and everything works as expected in my testing. Which I think makes sense, as we pass the session file path to the server and expect it to write the session file. I don't know why we had the client ever writing a session file. Furthermore, the only reference I can find to it in the server is with a writer, no reader. 🤷Related to #4071.