Revert modifications caused by Code's test run #3993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code 1.67.0 and up now modify the local `package.json` file during test run. Because we first run our tests in CI and then package our extension, this modification gets saved into the extension package. We need to check the file back out from Git after the test run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code 1.67.0 and up now modify the local
package.jsonfile during test run. Because we first run our tests in CI and then package our extension, this modification gets saved into the extension package. We need to check the file back out from Git after the test run.This was identified in microsoft/vscode#148975, and I confirmed that our latest preview unfortunately had this
__metadataadded to it. As I don't know what side effects that will have, let's prevent it from happening.