Skip to content

Fix how we check extension mode #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

andyleejordan
Copy link
Member

Well, this was dumb, and was the reason for red-herring logs in user reports that their extension was in development mode, and why our telemetry had stopped coming through.

@andyleejordan andyleejordan marked this pull request as ready for review May 19, 2022 17:12
@andyleejordan andyleejordan requested a review from a team May 19, 2022 17:12
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) May 19, 2022 17:14
@andyleejordan andyleejordan disabled auto-merge May 19, 2022 17:20
Well, this was dumb, and was the reason for red-herring logs in user
reports that their extension was in development mode, and why our
telemetry had stopped coming through.
@andyleejordan andyleejordan force-pushed the andschwa/extension-mode branch from c5daa42 to 58581d6 Compare May 19, 2022 17:40
@andyleejordan andyleejordan enabled auto-merge (squash) May 19, 2022 17:42
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit b4409fd into master May 19, 2022
@andyleejordan andyleejordan deleted the andschwa/extension-mode branch May 19, 2022 17:53
@andyleejordan andyleejordan mentioned this pull request May 20, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Bug A bug to squash.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants