Skip to content

Fix #396: Extension commands loaded in profile are not being registered #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Fix #396: Extension commands loaded in profile are not being registered #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,11 @@ export class SessionManager {
connectFunc,
clientOptions);

// Send the new LanguageClient to extension features
// so that they can register their message handlers
// before the connection is established.
this.updateExtensionFeatures(this.languageServerClient);

this.languageServerClient.onReady().then(
() => {
this.languageServerClient
Expand All @@ -345,19 +350,19 @@ export class SessionManager {
? `${this.versionDetails.displayVersion} (${this.versionDetails.architecture})`
: this.versionDetails.displayVersion,
SessionStatus.Running);

this.updateExtensionFeatures(this.languageServerClient)
});
},
(reason) => {
this.setSessionFailure("Could not start language service: ", reason);
this.updateExtensionFeatures(undefined);
});

this.languageServerClient.start();
}
catch (e)
{
this.setSessionFailure("The language service could not be started: ", e);
this.updateExtensionFeatures(undefined);
}
}

Expand Down