Pass EnableProfileLoading and InitialWorkingDirectory as initializationOptions
#3986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izationOptions` To fix stdio clients, we needed to fix our startup logic so that the PowerShell host was actually started on initialization, not in the `onDidChangeConfiguration` handler. The previous way it was done only worked because it relied on a quirk of the VS Code client to send that request immediately, which other clients don’t necessarily do. In order to startup sooner though, we need any configuration that’s applicable on startup to be passed across the wire with the `initialize` request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix stdio clients, we needed to fix our startup logic so that the PowerShell host was actually started on initialization, not in the
onDidChangeConfigurationhandler. The previous way it was done only worked because it relied on a quirk of the VS Code client to send that request immediately, which other clients don’t necessarily do. In order to startup sooner though, we need any configuration that’s applicable on startup to be passed across the wire with theinitializerequest.Pairs with PowerShell/PowerShellEditorServices#1801