Skip to content

Send p instead of \0 for sendKeyPress #3939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

andyleejordan
Copy link
Member

This sends a less-risky character in case PSReadLine does not consume it (due to a race condition). The p can be deleted and does ring the console bell.

@andyleejordan andyleejordan requested a review from a team April 26, 2022 18:58
@andyleejordan andyleejordan enabled auto-merge (squash) April 26, 2022 18:58
@andyleejordan andyleejordan disabled auto-merge April 26, 2022 18:58
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 4c90511 into master Apr 26, 2022
@andyleejordan andyleejordan deleted the andschwa/send-p-instead branch April 26, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants