Skip to content

Improve Settings Editor experience in a few places #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Apr 13, 2022

PR Summary

This PR is two commits:

  • two low hanging fruits that allow the CommandExplorerExcludeFilter and featureFlags settings to show up in the settings editor:
    image

  • a reworking of the powerShellAdditionalExePaths to be an object of { [versionName: string]: "exePath" } so that the user has a nicer experience in the settings editor. It's not perfect (I wish the Item and Value headers could be renamed), but it's the best we can do with the settings API today and think it's worth it.
    image

This also lights up nice things like this:
image

jumping to this:
image

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!!

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-UI labels Apr 13, 2022
@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Apr 13, 2022

@andschwa :shipit: 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants