Skip to content

Add PowerShell icon to Integrated Console #3897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

andyleejordan
Copy link
Member

Saw this option in the terminal creation options struct, tested it out, quite nice!

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-UI labels Mar 29, 2022
@JustinGrote
Copy link
Collaborator

JustinGrote commented Mar 29, 2022

Only issue I potentially have is that I used the new icon in my terminal profiles and made it easy to distinguish the PSIC from the "regular" terminals. I think this is still fine tho.

@andyleejordan
Copy link
Member Author

And I think that's actually a great reason to do this, since the default pwsh terminals opened by Code do not use the PowerShell icon. We can do so, and differentiate the PowerShell extension's integrated terminal from the others visually. (The opposite of what you'd done manually.)

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 🎉

@andyleejordan andyleejordan merged commit 1b830ce into master Mar 30, 2022
@andyleejordan andyleejordan deleted the andschwa/terminal-icon branch March 30, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants