Skip to content

Replace custom graphics with updated Codicons #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

Replace custom graphics with updated Codicons #3865

merged 1 commit into from
Mar 4, 2022

Conversation

andyleejordan
Copy link
Member

These look more like the rest of Code since they're built-in.

@andyleejordan
Copy link
Member Author

Some of the icons are a bit newer (particularly layout-* that just came out in 1.65.0), but theoretically everyone should have up-to-date VS Code, and the worst manifestation of this is just missing icons. Going to manually test that assumption though.

Before:

Screen Shot 2022-03-04 at 2 26 28 PM

Screen Shot 2022-03-04 at 2 26 43 PM

After:

Screen Shot 2022-03-04 at 2 25 07 PM

Screen Shot 2022-03-04 at 2 25 21 PM

@andyleejordan andyleejordan added Area-UI Issue-Enhancement A feature request (enhancement). labels Mar 4, 2022
@andyleejordan andyleejordan marked this pull request as ready for review March 4, 2022 22:32
andyleejordan
andyleejordan commented Mar 4, 2022
View reviewed changes
package.json
"title": "(Preview) PowerShell Command Explorer",
"icon": "media/pwsh.svg"
"title": "PowerShell Command Explorer",
"icon": "$(terminal-powershell)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 1.56!

package.json
"light": "media/resources/light/sync.svg",
"dark": "media/resources/dark/sync.svg"
},
"icon": "$(sync)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since <1.56

package.json
"light": "media/resources/light/pencil.svg",
"dark": "media/resources/dark/pencil.svg"
},
"icon": "$(pencil)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since <1.56

package.json
"light": "media/resources/light/question.svg",
"dark": "media/resources/dark/question.svg"
},
"icon": "$(question)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since <1.56

package.json Outdated
"light": "media/resources/light/run.svg",
"dark": "media/resources/dark/run.svg"
}
"icon": "$(run-all)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since <1.56. Could also just use $(run) (the single arrow, used next) and instead use $(debug-line-by-line) for "Run Selection" which would look like this:
Screen Shot 2022-03-04 at 2 42 07 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the current iteration. It looks more like what we had.

package.json Outdated
"light": "media/resources/light/ClosePanel.svg",
"dark": "media/resources/dark/ClosePanel.svg"
}
"icon": "$(layout-activitybar-left)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the next two are new and in 1.65.0. They're only seen in the ISE-mode. We could delay changing them until then. I guess Azure Data Studio users that use ISE-mode wouldn't see these, it'd look like this:
Screen Shot 2022-03-04 at 2 40 05 PM

Ok ok, we'll stash this part of the change for later.

@SydneyhSmith
Copy link
Collaborator

These changes look good to me!

@andyleejordan
Replace custom graphics with updated Codicon library
a80af7b 
These look more like the rest of Code since they're built-in.
@andyleejordan andyleejordan enabled auto-merge (squash) March 4, 2022 23:28
@andyleejordan andyleejordan changed the title Replace custom graphics with updated Codicon library Replace custom graphics with updated Codicons Mar 4, 2022
@andyleejordan andyleejordan disabled auto-merge March 4, 2022 23:28
@andyleejordan andyleejordan enabled auto-merge (squash) March 4, 2022 23:28
@andyleejordan andyleejordan merged commit 6b3008a into master Mar 4, 2022
@andyleejordan andyleejordan deleted the andschwa/codicons branch March 4, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SydneyhSmith SydneyhSmith SydneyhSmith approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@StevenBucher98 StevenBucher98 Awaiting requested review from StevenBucher98

Assignees
No one assigned
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Sea Biscuit
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SydneyhSmith