-
Notifications
You must be signed in to change notification settings - Fork 510
Introduce Debug
and Release
configurations
#3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f84612
to
3444a57
Compare
Release
task in Invoke-Build
c301a87
to
019112a
Compare
7e2d219
to
98210d2
Compare
Debug
and Release
configurations
@JustinGrote Want to help me merge this 😂 |
The debug build creates a symlink to PSES, rebuilds PSES, does not minify the extension, and generates a TypeScript sourcemap. The release build deletes the symlink if it exists and copies PSES, only builds PSES if not already copied, minifies the extension, and does not generate a TypeScript sourcemap. This removes the manual `LinkEditorServices` step and ensures that the developer debugging experience works well.
958967e
to
d396435
Compare
@andschwa shouldn't the code workspace include a debug build task? |
Also while not necessary to cover in this PR, I really would like to figure out a way to build a "watch" that, on C# change, would rebuild editor services and reload the extension host. dotnet watch run can cover the first part, I don't know if we can figure out a hook to reload the extension host debug process. |
Doesn't need a debug "task" since it has a debug launch configuration (both of them, actually): "Launch Extension" launches the extension under the VS Code debugger (and this PR explicitly ensure that actually works well by not minifying the code when developing), and "Attach to Editor Services" then will ask for the If you're asking if the build task needs to be in |
I'll look into it! |
LGTM then, I didn't notice debug was the default, that explains what I missed. |
Task was removed in PowerShell#3775, now automatic for Debug-builds.
Task was removed in #3775, now automatic for Debug-builds.
The debug build creates a symlink to PSES, rebuilds PSES, does not
minify the extension, and generates a TypeScript sourcemap. The release
build deletes the symlink if it exists and copies PSES, only builds PSES
if not already copied, minifies the extension, and does not generate a
TypeScript sourcemap. This removes the manual
LinkEditorServices
stepand ensures that the developer debugging experience works well.