Skip to content

Show powershell status only for powershell documents #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Dec 15, 2016

No description provided.

@msftclas
Copy link

Hi @kapilmb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Kapil Borle). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@daviwil
Copy link
Contributor

daviwil commented Dec 15, 2016

I'm going to wait on merging this one for a little while because I think there's some value in having the indicator visible when a PowerShell file isn't being edited.

One example: the user tries to create a new PowerShell project from template while they're editing a Markdown file and haven't activated the PowerShell extension yet. They should see the status bar indicator appear to know that PowerShell is being loaded and then active. Once the template creation is finished though, there's not as much reason to show it.

Let's wait and see if anyone complains about it being visible and then possibly merge this in 0.9.0.

@kapilmb
Copy link
Author

kapilmb commented Dec 15, 2016

I didn't see typscript or c# extension show their status on files that are not associated with them and I assumed that is the correct behavior. Also, it is a bit inconsistent that powershell status can be seen when you are actually editing a C# file but not the other way round.

@daviwil
Copy link
Contributor

daviwil commented Dec 15, 2016

OK, I'll merge it.

@daviwil daviwil merged commit f8332d0 into master Dec 15, 2016
@daviwil daviwil deleted the kapilmb/fix-status-bar-visibility branch December 15, 2016 19:36
@kapilmb
Copy link
Author

kapilmb commented Dec 15, 2016

Thanks @daviwil

@kapilmb
Copy link
Author

kapilmb commented Dec 15, 2016

I just went back and saw the code - I think these changes should cover the example you mentioned. Lets say, you create a new PowerShell project from a plaster template while editing a markdown - in that case the activation event triggers which should show PS status even though you are on a markdown file. Only when we change the active editor, the event triggers which then will take into account the document id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants