Support debugging without a workspace #3728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code assumed there was always at least one workspace folder, but this led to an error if there were zero. This can be reproduced by calling "Close Workspace" if one is open and then running Pester tests. Since the `vscode.debug.startDebugging()` interface does not require a workspace folder, and in fact expects "undefined" if none is available, we simply use TypeScript's "optional chaining" (AKA conditional access) operator to return undefined if `workspaceFolders` is null, and otherwise return the first workspace folder.
ghost
added
daxian-dbw
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code assumed there was always at least one workspace folder, but this led to an error if there were zero. This can be reproduced by calling "Close Workspace" if one is open and then running Pester tests. Since the
vscode.debug.startDebugging()interface does not require a workspace folder, and in fact expects "undefined" if none is available, we simply use TypeScript's "optional chaining" (AKA conditional access) operator to return undefined ifworkspaceFoldersis null, and otherwise return the first workspace folder.Fixes #3713.