Skip to content

Improve test stability with ensureEditorServicesIsConnected #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Oct 25, 2021

This uses a newly added ExternalApi function waitUntilStarted that ensures the LSP server (PowerShell session) is started after manually activating the extension.

@andyleejordan andyleejordan force-pushed the andschwa/test-stability branch from cbfb1cc to b8375b0 Compare October 26, 2021 16:39
@andyleejordan andyleejordan force-pushed the andschwa/test-stability branch from b8375b0 to 51580b6 Compare November 5, 2021 16:27
@andyleejordan andyleejordan marked this pull request as ready for review November 5, 2021 16:54
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This uses a newly added `ExternalApi` function `waitUntilStarted` that
ensures the LSP server (PowerShell session) is started after manually
activating the extension.
@andyleejordan andyleejordan force-pushed the andschwa/test-stability branch from 51580b6 to 07f42d1 Compare November 10, 2021 00:29
@andyleejordan andyleejordan merged commit 57b1749 into master Nov 10, 2021
@andyleejordan andyleejordan deleted the andschwa/test-stability branch November 10, 2021 00:44
@andyleejordan andyleejordan added Area-Test Issue-Enhancement A feature request (enhancement). labels Nov 10, 2021
@andyleejordan andyleejordan added this to the Committed-vNext milestone Nov 10, 2021
@andyleejordan andyleejordan mentioned this pull request Nov 10, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants