Clean up unit tests' descriptions and logical separation #3641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I read through all the tests in order to firstly understand fully what we're covering and secondly be able to write correct BDD-style descriptions. I also split tests up that could be for more logical separation, and formatted the files.
andyleejordan
added
Issue-Enhancement
|
Oh, I also enabled tests that had been previously disabled/skipped for reasons that are no longer applicable. We now have 55 separate unit tests, up from 35. |
rjmholt
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through all the tests in order to firstly understand fully what we're covering and secondly be able to write correct BDD-style descriptions. I also split tests up that could be for more logical separation, and formatted the files.